-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching between subtitles doesn't work (English -> None -> English) #296
Labels
Comments
Thanks for reporting! This is caused by stripping some metadata from the subtitle format and as a result the player can't find the track you selected. |
Is there any workaround I could use to fix this issue? |
rohitjoins
pushed a commit
that referenced
this issue
Apr 13, 2023
The overrides specified by a MediaController may not use the exact same TrackGroup instances as known to the Player because the groups have been bundled to and from the controller. This bundling may alter the instance slightly depending on the version used on each side of the communication and the fields set (e.g. Format.metadata is not supported for bundling). This issue can be solved by creating unique track group ids for each group on the session side before bundling. On the way back, the groups in the track selection parameters can be mapped backed to their original instances based on this id. #minor-release Issue: #296 PiperOrigin-RevId: 523986626
rohitjoins
pushed a commit
to google/ExoPlayer
that referenced
this issue
Apr 13, 2023
The overrides specified by a MediaController may not use the exact same TrackGroup instances as known to the Player because the groups have been bundled to and from the controller. This bundling may alter the instance slightly depending on the version used on each side of the communication and the fields set (e.g. Format.metadata is not supported for bundling). This issue can be solved by creating unique track group ids for each group on the session side before bundling. On the way back, the groups in the track selection parameters can be mapped backed to their original instances based on this id. #minor-release Issue: androidx/media#296 PiperOrigin-RevId: 523986626
rohitjoins
pushed a commit
that referenced
this issue
Apr 13, 2023
The overrides specified by a MediaController may not use the exact same TrackGroup instances as known to the Player because the groups have been bundled to and from the controller. This bundling may alter the instance slightly depending on the version used on each side of the communication and the fields set (e.g. Format.metadata is not supported for bundling). This issue can be solved by creating unique track group ids for each group on the session side before bundling. On the way back, the groups in the track selection parameters can be mapped backed to their original instances based on this id. #minor-release Issue: #296 PiperOrigin-RevId: 523986626
rohitjoins
pushed a commit
to google/ExoPlayer
that referenced
this issue
Apr 13, 2023
The overrides specified by a MediaController may not use the exact same TrackGroup instances as known to the Player because the groups have been bundled to and from the controller. This bundling may alter the instance slightly depending on the version used on each side of the communication and the fields set (e.g. Format.metadata is not supported for bundling). This issue can be solved by creating unique track group ids for each group on the session side before bundling. On the way back, the groups in the track selection parameters can be mapped backed to their original instances based on this id. #minor-release Issue: androidx/media#296 PiperOrigin-RevId: 523986626
rohitjoins
pushed a commit
that referenced
this issue
Apr 18, 2023
The overrides specified by a MediaController may not use the exact same TrackGroup instances as known to the Player because the groups have been bundled to and from the controller. This bundling may alter the instance slightly depending on the version used on each side of the communication and the fields set (e.g. Format.metadata is not supported for bundling). This issue can be solved by creating unique track group ids for each group on the session side before bundling. On the way back, the groups in the track selection parameters can be mapped backed to their original instances based on this id. Issue: #296 PiperOrigin-RevId: 523986626 (cherry picked from commit 1c557e2)
rohitjoins
pushed a commit
to google/ExoPlayer
that referenced
this issue
Apr 18, 2023
The overrides specified by a MediaController may not use the exact same TrackGroup instances as known to the Player because the groups have been bundled to and from the controller. This bundling may alter the instance slightly depending on the version used on each side of the communication and the fields set (e.g. Format.metadata is not supported for bundling). This issue can be solved by creating unique track group ids for each group on the session side before bundling. On the way back, the groups in the track selection parameters can be mapped backed to their original instances based on this id. #minor-release Issue: androidx/media#296 PiperOrigin-RevId: 523986626 (cherry picked from commit 07707c2)
v1.0.1 fixes the issue, thanks 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Media3 Version
Media3 1.0.0
Devices that reproduce the issue
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Yes
Reproduction steps
In the demo-session project inside
MediaItemTree
class comment out.setSubtitleConfigurations(subtitleConfigurations)
(line 88).Expected result
English subtitles should appear and be selected
Actual result
English subtitles doesn't appear
Media
https://d3rlna7iyyu8wu.cloudfront.net/skip_armstrong/skip_armstrong_stereo_subs.m3u8 (found on the internet)
Bug Report
adb bugreport
to [email protected] after filing this issue.The text was updated successfully, but these errors were encountered: