-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media3 MediaSession custom error messages #543
Comments
There is no such functionality in Media3. Who would be the consumer of the error messages? |
|
Also another point is although I could handle the error |
Yes, this is a regression compared with what's possible with the legacy API. |
@marcbaechinger do you hav any news on this ? |
Yeah, sorry no news yet. I don't think this will be part of 1.3 I'm afraid. We will update this issue as soon as we pushed a change that adds this. |
Our app update got rejected in playstore review because we didn't send error messages when using android auto. In other words this should be a blocker for many media app(s). |
@marcbaechinger have you any update about this limitation ? Is it planned for the next version ? |
This is planned for 1.4 which is the next release. |
This allows to set custom error message for instance on Android Auto/Automotive OS. Issue: #543 PiperOrigin-RevId: 633610089
The commit above added an API to send non-fatal errors to a When sent to all controllers or specifically to the media notification controller ( |
This change resets the error in the platform error state immediately to make sure that the custom error is reflected only very briefly and then gets back to the playback state that actually reflects the player state. Issue: #543 PiperOrigin-RevId: 633626180
Hello! Any updates on this? Or any suggestion how to do authentication on Automotive OS with Media3: https://developer.android.com/training/cars/media/automotive-os#require-sign-in? Thanks! |
Is there a reason why a resource Id is necessary? Could the method not accept just a plain string as well? |
This API has changed. The change that includes this is on its way into the main branch. There will be a |
@marcbaechinger thats great! I do plan on using a localized string, only we dont use the android resources in our project, but an alternative solution |
Is there a potential release date for 1.4? |
We are currently preparing the beta01. The stable release of 1.4.0 is expected to be in mid July. |
Thanks for reporting. What did you do this in the old world to make 'close the "player view" in android auto'? Not sure if this is what you are asking about, but I mean to remember that you can send a This is documented here: https://developers.google.com/cars/design/create-apps/media-apps/signin-flow If this is the case, then you can add the same extras key/value to the
|
@marcbaechinger can you think of any way in how to replicate the old behaviour described above? |
I think Media3 is currently missing an API to send a custom fatal exception in an easy way. The current version allows to send non-fatal errors as you do and it allows to customize error code and error message of a Sorry for not having a better answer than that we should prioritize this to provide this with the next release. |
Is there an equivalent in media3 for these?
MediaSessionConnector.setCustomErrorMessage()
to send a custom error message regardless of player state.MediaSessionConnector.setErrorMessageProvider(PlayerErrorMessageProvider)
to convert PlaybackException to a custom error message for connected controllers.The text was updated successfully, but these errors were encountered: