-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow client-side preroll ads with SSAI (DAI) stream #571
Comments
Looks like Although I did as below but no success. There is no Pre-Roll is played. Just Mid-Roll.
|
@devno44 For client-side ad insertion, please use |
@tonihei
Not only for client-side ad insertion or server-side ad insertion. Is there any way to do it ? Thank you ! |
Do I understand the problem correctly that you'd like to combined client-side ad insertion for the preroll with server-side ad insertion for the main stream? So that the result looks something like:
Is this correct? If so, this is currently unsupported because our client-side |
@tonihei Please add this feature. Thank you so much. |
There is a workaround where you add the pre-roll with a media item with 0 duration and the DAI source as different items in a playlist. Generating this empty source for the preroll requires you to use
This should work for HLS streams already, but we discovered a bug for multi-period DASH that needs to be fixed first. Once the fix is in, this workaround also works for DASH streams. |
@tonihei Can you please check if is there something wrong on my implementation ?
|
I think the second item should use |
@tonihei I tried to use |
This works without issues in the demo app. You should probably check the pre-roll AdsMediaSource on its own to see if it works and try out your streams in the demo app. If you think there is a bug, please provide more details about your actual strreams, so we can reproduce the issue. (You can send links to [email protected] with "Issue #571" in the subject if needed). |
The period index was calculated relative to the contentTimeline of the DAI stream, but then used with the full timeline of the player. This means it currently only works when the stream is the only or first item in the playlist. Issue: #571 PiperOrigin-RevId: 560023412
The period index was calculated relative to the contentTimeline of the DAI stream, but then used with the full timeline of the player. This means it currently only works when the stream is the only or first item in the playlist. Issue: androidx/media#571 PiperOrigin-RevId: 560023412
The period index was calculated relative to the contentTimeline of the DAI stream, but then used with the full timeline of the player. This means it currently only works when the stream is the only or first item in the playlist. Issue: androidx#571 PiperOrigin-RevId: 560023412
Hello,
I have a live content that need have to play both of Pre-Roll and Mid-Roll.
So I have a question, How can I implement Pre-Roll and Mid-Roll at the same Player ?
If possible, can you provide an example for the implementation ?
For SSAI, I want to use
ImaServerSideAdInsertionMediaSource
The version of ExoPlayer that I am using is ExoPlayer 2.18.3.
Streaming protocol is HLS.
Thank you
The text was updated successfully, but these errors were encountered: