-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTP VP8 test #110
base: main
Are you sure you want to change the base?
Add RTP VP8 test #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, merging internally.
...ies/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpVp8ReaderTest.java
Outdated
Show resolved
Hide resolved
Set the fixed clock rate in VP8 Reader Test Change-Id: I0bdedc803bb892d93fde2a027a01cb49a48597ef
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVp8Reader.java
Outdated
Show resolved
Hide resolved
PiperOrigin-RevId: 460513413
Reset fragmentedSampleSizeBytes to LENGTH_UNSET. Change-Id: Ie8a66702a7e26b5e240a7163dac6343531f1b49f
The merge commit 9d9bbe3, addresses the two review comments. We can skip these 2 commits. |
PiperOrigin-RevId: 460513413 (cherry picked from commit 9d9bbe3)
Thanks for making the change. Could you create a new PR for the two recent commits, as the original PR is already merged into |
The review comments addressed in the recent two commits are already resolved in commit 9d9bbe3 and merged on main. We can discard the recent two commits. |
PiperOrigin-RevId: 460513413 (cherry picked from commit c75b6a3)
PiperOrigin-RevId: 460513413
Exoplayer RTP VP8 Reader had few issues.
Created a issue describing the same.
Fixed the reported issue in the PR and added RTP VP8 tests as well.