Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoFn.teardown metrics are lost in Python SDK #19394

Open
kennknowles opened this issue Jun 3, 2022 · 0 comments
Open

DoFn.teardown metrics are lost in Python SDK #19394

kennknowles opened this issue Jun 3, 2022 · 0 comments

Comments

@kennknowles
Copy link
Member

If user code in DoFn.shutdown updates custom user metrics, those updates will not get registered e.g. counter increments are not registered.

Context: In FnApiRunner.run_stages, DoFn.teardown is called in worker_handler_manager.close_all, but this is called outside of the FnApiRunner.run_stage calls, so no metrics / monitoring info is retrieved there.

Imported from Jira BEAM-7340. Original Jira may contain additional context.
Reported by: [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants