Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-12213] Enable dual job submission for Dataflow #14633

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

kennknowles
Copy link
Member

This is a follow-up from #14614, finally enabling dual job submission, both portable and non-portable in a single job submission.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kennknowles
Copy link
Member Author

Run Java Examples on Dataflow Runner V2

@kennknowles
Copy link
Member Author

Run Java Dataflow V2 ValidatesRunner

1 similar comment
@kennknowles
Copy link
Member Author

Run Java Dataflow V2 ValidatesRunner

@kennknowles
Copy link
Member Author

This requires #13053 because the translator does not know how to handle portable side inputs. We need to unconditionally have portable side inputs for the portable submission and non-portable side inputs for the non-portable submission.

@kennknowles
Copy link
Member Author

Run Java Examples on Dataflow Runner V2

@kennknowles kennknowles marked this pull request as ready for review April 27, 2021 21:00
@kennknowles
Copy link
Member Author

R: @chamikaramj

@kennknowles
Copy link
Member Author

run java precommit

@kennknowles
Copy link
Member Author

Also R: @ihji because this is marked for 2.30.0

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@kennknowles
Copy link
Member Author

Run Java PreCommit

1 similar comment
@kennknowles
Copy link
Member Author

Run Java PreCommit

@kennknowles kennknowles merged commit a25261a into apache:master Apr 28, 2021
@kennknowles kennknowles deleted the dual-submission branch April 28, 2021 04:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants