[BEAM-10496] Eliminate some null errors from sdks/java/core #17819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Java PreCommit |
0b1f3fd
to
1321418
Compare
|
Run Java PreCommit |
1321418
to
5423f4c
Compare
|
run java precommit |
|
Run Java_Examples_Dataflow_Java17 PreCommit |
|
amusingly, NPEs in elasticsearch test, plus flaking in pulsar test and file io |
|
Run Java PreCommit |
|
Our flakes are driving me nuts - confirmed some of these tests seem OK locally. I'll rebase and push just to get any recent fixes and have to kick jenkins less. |
5423f4c
to
8ce5a6f
Compare
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
|
Run Java PreCommit |
kileys
reviewed
Jun 28, 2022
| @@ -99,16 +97,19 @@ public static Map<TupleTag<?>, PCollection<?>> fullyExpand( | |||
| PCollection.class.getSimpleName(), | |||
| valueComponent.getValue())); | |||
| } | |||
| @Nullable | |||
There was a problem hiding this comment.
How come the other ones doesn't need the @nullable?
| @@ -180,7 +178,7 @@ public Class<? super T> getRawType() { | |||
|
|
|||
| /** Returns the component type if this type is an array type, otherwise returns {@code null}. */ | |||
| @Nullable Object p1, | ||
| @Nullable Object p2) { | ||
| if (obj == null) { | ||
| throw new IllegalStateException(lenientFormat(errorMessageTemplate, p1)); |
|
Any update on this PR? |
|
Still waiting to find time to resolve conflicts and address comments. |
8ce5a6f
to
c06fb49
Compare
c06fb49
to
1722ad9
Compare
|
Run Java PreCommit |
kileys
approved these changes
Aug 23, 2022
|
Hrmm. One of the licenses that we download the server is down. bouncycastle.org |
|
run java precommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-activated nullness type checking for a portion of
org.apache.beam.sdk.valuesnamespace.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.