-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go SDK]: Implement standalone single-precision float encoder #22664
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22664 +/- ##
=======================================
Coverage 74.19% 74.19%
=======================================
Files 708 709 +1
Lines 93465 93489 +24
=======================================
+ Hits 69347 69365 +18
- Misses 22843 22847 +4
- Partials 1275 1277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I recommend also adding a mention of this to Changes.md, in particular in the breaking changes section, as most coder changes are "breaking", and that this is user observable behavior in the coding.
…#22664) * Implement standalone single-precision float encoder * Add fuzz test * Fix buffer size * Fix docstring * Add CHANGES.md entry
Implements a specific single-precision float coder to match Java and Python coder implementations, replacing old routing that treated
float32
values asfloat64
for encoding/decoding purposes.Fixes #22629
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.