-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
22805: Upgrade Jackson version from 2.13.0 to 2.13.3 #22806
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22806 +/- ##
==========================================
+ Coverage 74.09% 74.16% +0.06%
==========================================
Files 712 712
Lines 93832 94116 +284
==========================================
+ Hits 69524 69797 +273
- Misses 23028 23039 +11
Partials 1280 1280
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@pabloem can you please check on this review? |
Reminder, please take a look at this pr: @damccorm |
retest this please |
(talking to the bot to get it to rerun checks since there was a license issue causing problems ^) |
@perkss looks like this is causing pulling licenses to fail with:
Could you take a look? Looks like we should just need to add a type field here -
|
78273d0
to
4e5ff94
Compare
Thanks yes should have spotted this updated now |
Run Typescript PreCommit |
Run SQL PreCommit |
Run Python PreCommit |
2 similar comments
Run Python PreCommit |
Run Python PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Fix issues #22805
Upgrade Jackson version from vulnerable 2.13.0 to 2.13.3. As per snyk
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.