Run cred rotation every month #22977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial bi-monthly frequency was proposed given the credentials lifetime reported by this command. As all the jobs get their cluster credentials dynamically through gcloud, I think there won't be a huge impact if those are rotated on a more frequent basis. |
|
R: @Abacn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Thanks. Is the original every other month setting never working? |
|
It ran for the first time a little less than 2 months ago, but the creds expired before the second run. Had there been a run in between we would've most likely avoided the problem |
Abacn
approved these changes
Aug 31, 2022
dedocibula
pushed a commit
to dedocibula/beam
that referenced
this pull request
Sep 15, 2022
kkdoon
pushed a commit
to twitter-forks/beam
that referenced
this pull request
Sep 29, 2022
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins recently went down for a while because our creds expired. Running the IODatastores rotation job fixed it. Given that its relatively cheap, we should probably run that job every month so that we're not cutting it close on expirations. I could actually be convinced that running it even more frequently is a good idea.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.