tests: fixes SpannerIO unavailable retry test #23748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The failing test exercises the retry mechanism of the Cloud Spanner client when receiving UNAVAILABLE exceptions. Since this error is retried forever, the test is configured to retry for a while and cancel the pipeline. The wait time was too low and no requests were retried. Here we update the wait time from 5ms to 500ms, which gives the pipeline more time to retry requests. Fixes apache#21533
|
Assigning reviewers. If you would like to opt out of this review, comment R: @lukecwik for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Locally when I increased it to 1000 millis I still had the error. But if this works for you and in CI then I trust I just had confused myself! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing test exercises the retry mechanism of the Cloud Spanner client when receiving UNAVAILABLE exceptions. Since this error is retried forever, the test is configured to retry for a while and cancel the pipeline. The wait time was too low and no requests were retried.
Here we update the wait time from 5ms to 500ms, which gives the pipeline more time to retry requests.
Fixes #21533