KAFKA-15669: Implement telemetry metric naming strategy (KIP-714) #14619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
AndrewJSchofield
approved these changes
Oct 23, 2023
...ts/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java
Outdated
Show resolved
Hide resolved
|
Depends on PR - #14575 for build. |
mjsax
reviewed
Oct 27, 2023
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
...ts/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricNamingConvention.java
Outdated
Show resolved
Hide resolved
xvrl
reviewed
Oct 27, 2023
| * This class encapsulates naming and mapping conventions defined as part of | ||
| * <a href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability#KIP714:Clientmetricsandobservability-Metricsnamingandformat">Metrics naming and format</a> | ||
| */ | ||
| public class MetricNamingConvention { |
There was a problem hiding this comment.
maybe a more explicit class name would help here. Since the goal of this mapping is to map the metric names to something that fits OpenTelemetry conventions, maybe we can call this OpenTelemetryMetricNamingConvention ?
There was a problem hiding this comment.
I have changed name to TelemtryMetricNamingConvention as we generally referred by same in KIP. Let me know if it works or we still feel that the name should be more specific as you suggested.
xvrl
reviewed
Oct 27, 2023
...ts/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java
Outdated
Show resolved
Hide resolved
wcarlson5
approved these changes
Oct 31, 2023
|
The tests failing are not related to this PR |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…ache#14619) The PR defines the naming convention for telemetry metric names for KIP-714 - jira. Telemetry metric name should be dot separated and tags should be snake case. PR adds the interface which will be used in MetricsReporter implementation to construct metric names. Reviewers: Xavier Léauté <[email protected]>, Walker Carlson <[email protected]>, Matthias J. Sax <[email protected]>, Andrew Schofield <[email protected]>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…ache#14619) The PR defines the naming convention for telemetry metric names for KIP-714 - jira. Telemetry metric name should be dot separated and tags should be snake case. PR adds the interface which will be used in MetricsReporter implementation to construct metric names. Reviewers: Xavier Léauté <[email protected]>, Walker Carlson <[email protected]>, Matthias J. Sax <[email protected]>, Andrew Schofield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR defines the naming convention for telemetry metric names for KIP-714 - jira. Telemetry metric name should be dot separated and tags should be snake case.
PR adds the interface which will be used in MetricsReporter implementation to construct metric names.
Committer Checklist (excluded from commit message)