KAFKA-15859: Add timeout field to the ListOffsets request #17112
+125
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not dependent on #16602 and can be reviewed separately. PTAL. |
kamalcph
commented
Sep 6, 2024
| "validVersions": "0-9", | ||
| // | ||
| // Version 10 enables async remote list offsets support (KIP-1075) | ||
| "validVersions": "0-10", |
There was a problem hiding this comment.
since we have flexible versions from v6, is it required to bump the version to 10?
fbede17
to
77671e3
Compare
3 tasks
1a91702
to
c0f94be
Compare
|
This is the final part-3 of KIP-1075. The PR is ready for review. PTAL. Thanks! |
satishd
reviewed
Sep 16, 2024
| ]} | ||
| ]}, | ||
| { "name": "TimeoutMs", "type": "int32", "versions": "10+", | ||
| "about": "The timeout to await a response in milliseconds for remote requests." } |
There was a problem hiding this comment.
You can update the doc with more details like below.
"The timeout to await a response in milliseconds for the requests that require reading from remote storage for topics that are enabled with tiered storage."
c0f94be
to
61ded02
Compare
61ded02
to
4c274e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part-3 of the KIP-1075
Added a
timeoutMsfield to the ListOffsets request. This timeout is applicable only for the topic/partitions that are enabled with remote storage.When the timeout is defined in the request, then we use it to define the delay timeout for DelayedRemoteListOffsets request. When the timeout is not defined (requests from older client), then we take the dynamic
remote.list.offsets.request.timeout.msserver config as the timeout.Consumer and Admin client behavior are different. Consumer retries the LIST_OFFSETS request in-case of an error but not the AdminClient. And, consumer timeouts the request, if the response exceeds
request.timeout.ms, whereas, AdminClient timeouts the request when it exceeds thedefault.api.timeout.ms.To retain the same behavior, we are passing the requestTimeoutMs as timeout from the consumer and defaultApiTimeout / overwritten ListOffsetsOption timeout from the admin.
Committer Checklist (excluded from commit message)