-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(helm): Allow chart operators to exclude the creation of the secret manifest #28308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You'll need to re-gen the chart readme and bump the chart version
Sure, will do, also verify, I'm suspicious of how helm would deal with the declaimer header, then the if, I'll test that as well |
seems legit 👍 Locally against my PR branch with default values (explicit default for new parameter)
And now with the new parameter as false:
|
Done, bumped & generated |
Just for future reference and search indexing,
|
SUMMARY
Allow chart operators to exclude the creation of the secret manifest,
This would effectively support externally created secret - specifically for the template secret-env.yaml
From externally created sources such as sealed-secrets or external-secrets and others..