Avoid allocating OrderedSet in UnionBuilder::simplify
#13206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e9ef88
to
5af1423
Compare
|
dhruvmanila
reviewed
Sep 2, 2024
Comment on lines
85
to
89
| match self.elements.len() { | ||
| 0 => Type::Never, | ||
| 1 => self.elements[0], | ||
| _ => Type::Union(UnionType::new(self.db, self.elements)), | ||
| } |
There was a problem hiding this comment.
nit: we could match against a slice of elements (as_slice) to avoid indexing
There was a problem hiding this comment.
Unfortunately not. The OrderedSet::as_slice method doesn't return a regular slice. It's a newtype wrapper around Slice that doesn't support matching.
AlexWaygood
approved these changes
Sep 2, 2024
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Calling
OrderedSet::is_supersetwith a[...].into()allocates a newOrderedSet. The compiler may be able tofigure out that the set isn't strictly necessary, although I doubt that it is (requires reasoning across
is_supersetandInto).This PR removes the
is_supersetcall with two simplecontainscalls. It also tries to preserve the type orders(which may also help with performance because
removein anOrderedSetisO(n).Test Plan
cargo test