chore: only run net48 on windows and use node 17 to run integration-node #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
reviewed
Mar 7, 2024
Comment on lines
117
to
121
| os: [ | ||
| windows-latest, | ||
| ubuntu-latest, | ||
| macos-latest, | ||
| ] |
There was a problem hiding this comment.
Issue: I think I never figured out Zip file creation on Windows.
So this Job cannot work on Windows.
See line 170 or the step that creates the Zip.
Comment on lines
120
to
129
| # - name: Fetch awses-decrypt/python-2.3.0.zip | ||
| # working-directory: ./ | ||
| # shell: bash | ||
| # run: | | ||
| # PYTHON_23_VECTOR_PATH=$GITHUB_WORKSPACE/python23/vectors | ||
| # mkdir -p $PYTHON_23_VECTOR_PATH | ||
| # DOWNLOAD_NAME=python23.zip | ||
| # curl --no-progress-meter --output $DOWNLOAD_NAME --location $VECTORS_URL | ||
| # unzip -o -qq $DOWNLOAD_NAME -d $PYTHON_23_VECTOR_PATH | ||
| # rm $DOWNLOAD_NAME |
There was a problem hiding this comment.
Question/Issue: Why not just delete this content?
There was a problem hiding this comment.
testing stuff out, not want to delete this yet
texastony
previously approved these changes
Mar 9, 2024
Comment on lines
168
to
179
| # - name: Generate Test Vectors with .NET Framework net6.0 | ||
| # # TODO Post-#619: Fix Zip file creation on Windows | ||
| # if: matrix.os != 'windows-latest' | ||
| # working-directory: ./AwsEncryptionSDK | ||
| # shell: bash | ||
| # run: | | ||
| # NET_41_VECTOR_PATH=$GITHUB_WORKSPACE/net41/vectors | ||
| # mkdir -p $NET_41_VECTOR_PATH | ||
| # GEN_PATH=runtimes/net/TestVectorsNative/TestVectorGenerator | ||
| # dotnet run --project $GEN_PATH --framework net6.0 -- \ | ||
| # --encrypt-manifest $GEN_PATH/resources/0006-awses-message-decryption-generation.v2.json \ | ||
| # --output-dir $NET_41_VECTOR_PATH |
There was a problem hiding this comment.
I want to leave it to come back to fix the zip on windows problem
josecorella
commented
Mar 9, 2024
texastony
approved these changes
Mar 9, 2024
rishav-karanjit
added a commit
that referenced
this pull request
May 9, 2024
## 4.1.0 ### Notes - [(#646)](10daadf) Enforces input constraints. Prior to this fix, the AWS Encryption SDK in .NET (ESDK-NET) failed to enforce user input constraints. Input shapes without required members set would always result in a `NullReferenceException`. Now, the ESDK-NET will throw its own Exceptions when illegal user input is submitted. ### Fixes * fix: throw an exception when MemoryStream instance has an empty backing array [(#633)](550c714) ### Features * feat: enforce input constraints [(#646)](10daadf) ### Maintenance * fix(CI): Daily CI uses correct workflow [(#641)](771835e) * chore(ci): fix role to assume [(#622)](c1f04fc) * chore(CI/CD): add semantic release automation [(#647)](e7b5392) * chore: Adopt SmithyDafnyMakefile.mk, fix nightly build [(#638)](cd19979) * chore(CI): add interop tests to daily ci [(#640)](c9ad018) * chore: only run net48 on windows and use node 17 to run integration-node [(#639)](d6c62fb) * chore(.NET): Add ESDK-Net v4.0.1 generated vectors[(#636)](efef497) * chore(NET-SupportPolicy): Mark 3.x as Support [(#631)](3c36f7a) * chore: Add manual trigger for nightly_dafny.yml [(#629)](419b1cb) * chore: split vc gen on some methods to migrate to Dafny 4.4 [(#627)](fdc65ca) * test: restore CODEOWNERS and daily CI [(#624)](ff823ac) * chore: update template to point to public repo [(#626)](2b07a39) * chore: remove unused release step in test-prod [(#623)](9883933)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.