Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sensitive missing on list/map #5313

Merged
merged 1 commit into from
Jul 22, 2024
Merged

fix sensitive missing on list/map #5313

merged 1 commit into from
Jul 22, 2024

Conversation

lucix-aws
Copy link
Contributor

Applies sensitive:true to list/map fields with sensitive targets e.g.

diff --git a/service/appflow/api.go b/service/appflow/api.go
index 1399352be..1dd952812 100644
--- a/service/appflow/api.go
+++ b/service/appflow/api.go
@@ -5907,7 +5907,7 @@ type CustomAuthCredentials struct {
        _ struct{} `type:"structure"`
 
        // A map that holds custom authentication credentials.
-       CredentialsMap map[string]*string `locationName:"credentialsMap" type:"map"`
+       CredentialsMap map[string]*string `locationName:"credentialsMap" type:"map" sensitive:"true"`
 
        // The custom authentication type that the connector uses.
        //

Tested:

package main

import (
	"fmt"

	"github.com/aws/aws-sdk-go/aws"
	"github.com/aws/aws-sdk-go/service/appflow"
)

func main() {
	fmt.Println(appflow.CustomAuthCredentials{
		CredentialsMap: map[string]*string{
			"foo": aws.String("bar"),
		},
	})
}

Before:

{
  CredentialsMap: {
    foo: "bar"
  }
}

After:

{
  CredentialsMap: <sensitive>
}

@lucix-aws lucix-aws merged commit e65d388 into main Jul 22, 2024
9 checks passed
@lucix-aws lucix-aws deleted the fix-sensitivelistmap branch July 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants