-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get-started.mdx #16322
Update get-started.mdx #16322
Conversation
the previous command wasnt actually creating it to framework as nextjs, changing the tag is initializing next repo
hello @IgorMinar can you look into this once |
Thanks for the PR @swarajbachu 🙂 Could you please update your PR to use the Something like:
That will make sure that we do get the right command for the various package managers 🙂 PS: if you could apply the change also to all the other guides under |
sure, lemme do that |
just one thing to note is that this means it will appear
instead of
or I can do
but it doesn't seem to be a good practice so for now I am doing the way you told me to do, lemme know if you need to change it further |
@dario-piotrowicz updated the way you mentioned for now |
@swarajbachu thanks so much for updating the guides, it's really very much appreciated! As you pointed out in your comment my suggestion wasn't actually fully correct (I did it on the spot as an example without checking things too much, sorry for the confusion) I think that the right change would then be: <PackageManagers
type="create"
pkg="cloudflare@latest"
args="my-next-app --framework=next"
/> This does seem to produce the correct results: and it's not, as far as I can tell, bad practice or anything like that. What do you think? could you make this one last change? (to all the guides as well 😅) 🙏 |
hmm yeah cool, now I am will do that, and do you want me to also add |
@swarajbachu thanks a lot! ❤️
I'm not sure 😕 (I guess it depends how much extra code that would entail) I'd avoid that for now, the best person to ask would be @KianNH, but he's currently on holiday I believe I'm not sure if Kian has already considered/looked into bun, to avoid delays with merging this PR I would just avoid adding bun and potentially think of such addition as a followup 🙂 |
cool lemme do the remaining changes then |
@dario-piotrowicz done dude |
hello dude @dario-piotrowicz |
@swarajbachu sorry I was unable to review the PR yesterday 🙇, I'm having a look right now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job @swarajbachu, thanks so very much for the various updates! 🫶
I've left a few comments for things that need amending, besides these small changes it looks great to me 😄
src/content/docs/pages/framework-guides/deploy-a-svelte-site.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pages/framework-guides/deploy-a-vite3-project.mdx
Outdated
Show resolved
Hide resolved
src/content/docs/pages/framework-guides/deploy-an-analog-site.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Dario Piotrowicz <[email protected]>
Thanks for the contribution, @swarajbachu, I'll merge as soon as checks pass. Definitely appreciate the help here making sure other folks don't run into the issue you experienced. |
Congratulations @swarajbachu, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm0qzwju811720cjqvvwfw1h5 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
the previous command wasnt actually creating it to the framework as next, changing the tag is initializing the next project
Summary
the command was about starting a new next project, but it is instead just running to create a normal project
Screenshots (optional)
previous