Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the pod label selector configurable #100

Closed
stefanprodan opened this issue Mar 13, 2019 · 0 comments · Fixed by #148
Closed

Make the pod label selector configurable #100

stefanprodan opened this issue Mar 13, 2019 · 0 comments · Fixed by #148
Labels
kind/enhancement Improvement request for an existing feature

Comments

@stefanprodan
Copy link
Member

Flagger assumes that a deployment specifies the pod label selector using the app convention. We should support other label names like app.kubernetes.io/name or name.

The label name or names could be specified as command flag.
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Mar 13, 2019
@stefanprodan stefanprodan mentioned this issue Apr 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the pod selector label configurable fluxcd/flagger
1 participant
@stefanprodan