Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to disable cross namespace refs to Custom Resources #1181

Merged
merged 3 commits into from
May 3, 2022

Conversation

aryan9600
Copy link
Member

Signed-off-by: Sanskar Jaiswal [email protected]

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this flag to the Helm chart and document what it does in the chart readme.

@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Apr 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #1181 (30ed9fb) into main (a1e519b) will increase coverage by 0.13%.
The diff coverage is 38.88%.

@@            Coverage Diff             @@
##             main    #1181      +/-   ##
==========================================
+ Coverage   56.78%   56.91%   +0.13%     
==========================================
  Files          79       79              
  Lines        6622     6631       +9     
==========================================
+ Hits         3760     3774      +14     
+ Misses       2304     2301       -3     
+ Partials      558      556       -2     
Impacted Files Coverage Δ
pkg/router/gateway_api.go 44.69% <ø> (+1.15%) ⬆️
pkg/controller/controller.go 8.49% <36.36%> (+7.77%) ⬆️
pkg/controller/scheduler_metrics.go 36.08% <50.00%> (-1.04%) ⬇️
pkg/controller/events.go 56.19% <100.00%> (+3.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e519b...30ed9fb. Read the comment docs.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 please reword the last commit to "Add cross-namespace refs to FAQ".

Sanskar Jaiswal added 2 commits April 29, 2022 13:50
@aryan9600 aryan9600 changed the title Add flag to disable cross namespace refs to AlertProviders and MetricTemplates Add flag to disable cross namespace refs to Custom Resources Apr 29, 2022
@stefanprodan stefanprodan merged commit a8b4e9c into fluxcd:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants