Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add namespace to namespaced resources in chart templates #1370

Merged

Conversation

thechristschn
Copy link

This will add the namespace to namespaced resources in the flagger helm chart.

This was already done for some resources, e.g. the podmonitor or prometheus deployment, but was missing at other places.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @thechristschn

@stefanprodan stefanprodan changed the title Add namespace to namespaced resources in helm chart helm: Add namespace to namespaced resources in chart templates Feb 20, 2023
@stefanprodan stefanprodan merged commit e263d6a into fluxcd:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants