Make the pod selector label configurable #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default labels: app, name and app.kubernetes.io/name
sarialem
reviewed
Jan 9, 2020
| @@ -96,6 +96,9 @@ spec: | |||
| app: podinfo | |||
| ``` | |||
|
|
|||
| Besides `app` Flagger supports `name` and `app.kubernetes.io/name` selectors. If you use a different | |||
| convention you can specify your label with the `-selector-labels` flag. | |||
There was a problem hiding this comment.
It was really difficult to know where to use this flag from this documentation, I had to come to this PR to realize that it should be used when installing flagger with helm, or maybe I'm still wrong, how is it used?
There was a problem hiding this comment.
The Helm options are documented in the chart readme here to set a label with Helm you would do --set selectorLabels=somelabel
There was a problem hiding this comment.
Can you please open an issue for making the docs better around selector-labels, the Helm example should probably be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new flag named
selector-labelsthat allows the pod selector match label to be configured at run time.By default Flagger will search for one of the following labels:
appnameapp.kubernetes.io/nameIf none of the above labels are found in
Deployment.Spec.Selector.MatchLabelsthe canary is rejected.Fix: #100