Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatewayapi: add support for v1 #1557

Merged
merged 4 commits into from
Nov 30, 2023
Merged

gatewayapi: add support for v1 #1557

merged 4 commits into from
Nov 30, 2023

Conversation

aryan9600
Copy link
Member

@aryan9600 aryan9600 commented Nov 28, 2023

Add support for Gateway API v1. Drop support for v1alpha2, since we deprecated support for it more than a year ago and almost all implementations have moved on to v1beta1.

Switch from Contour to Istio for e2e tests due to lack of support for the v1 APIs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (3e87c15) 55.03% compared to head (e595f47) 55.13%.
Report is 2 commits behind head on main.

❗ Current head e595f47 differs from pull request most recent head 37621de. Consider uploading reports for the commit 37621de to get more accurate results

Files Patch % Lines
pkg/router/gateway_api.go 57.50% 148 Missing and 5 partials ⚠️
pkg/router/factory.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
+ Coverage   55.03%   55.13%   +0.10%     
==========================================
  Files          85       85              
  Lines       10355    10639     +284     
==========================================
+ Hits         5699     5866     +167     
- Misses       3994     4104     +110     
- Partials      662      669       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aryan9600 aryan9600 force-pushed the gatewayapi-v1 branch 9 times, most recently from ac56f6a to daf52dd Compare November 29, 2023 12:44
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Nov 29, 2023
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🏅

Add support for v1 of Gateway API `HTTPRoute`. Drop support for v1alpha2
as it was deprecated almost a year ago.

Signed-off-by: Sanskar Jaiswal <[email protected]>
Bump Gateway API E2E tests to v1 and switch to Istio from Contour.

Signed-off-by: Sanskar Jaiswal <[email protected]>
@aryan9600 aryan9600 force-pushed the gatewayapi-v1 branch 2 times, most recently from afa3e8b to e595f47 Compare November 30, 2023 07:21
@aryan9600 aryan9600 merged commit e9b8dee into main Nov 30, 2023
17 checks passed
@aryan9600 aryan9600 deleted the gatewayapi-v1 branch November 30, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants