-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for preview images AdaptionSet/Representation in DASH #3752
Comments
Hello. Any update on this? |
I'd like to know if there's any way to do this now too (showing preview while seeking), please help. Thanks. |
I'd want to know how to seek and preview real-time. Thanks. |
@drjunja86 - There is no update on this currently, sorry. |
@ojw28 Is there any new information on this issue? |
hi @ppodgorski |
Looking forward to the support of DASH tiles thumbnail seeking in ExoPlayer as the native android-player. |
Any update/plans on implementing this? Thanks. |
Also interested to get a status update and to evaluate how we can make it happen together as a community. |
For reference (and interop testing), here are some sample streams that work with dash js:
|
Hi Olly @ojw28, It seems there is an industry wide interest to make this feature happening, we would be ready to assign Java developer if we have a chance to make as a core exoplayer feature. What would be your guidelines to succeed ? |
Hello But first, is Exoplayer team motivated to do such a feature or to help do it by providing all necessary support? Can any developer describe the process to validate a merge request in ExoPlayer project? thanks |
We would welcome a high quality contribution in this area. That said, we see this feature as a pretty difficult one. It's not immediately clear to us (the core dev team) what the best way of implementing it is, and so someone would need to spend some time coming up with a detailed proposal (or proposals) for review. In terms of maximizing the probability that a contribution would be useful, I'd therefore suggest that a contributor should start by writing a fairly thorough design proposal before anything else, that can be reviewed. To write such a proposal it may of course be necessary to hack around in code a little, to learn about what's already there and figure out what's possible, but I'd expect the design proposal to precede actual pull requests. You can see some past examples of design proposals here to get an idea of the kind of thing we'd be looking for. Once we're able to agree on a design, implementation is (probably!) the easier part :). |
Hello @ojw28, hello community, thank you for providing the information on how to contribute via design proposal. We would like to share this proposal regarding "Add support for thumbnail/preview images from AdaptationSets in DASH" with you and the community (Google Docs document). We're looking forward to feedback, discussion and the okay for the start of implementation. Regards |
Thanks for putting together this proposal! Looks like you are addressing multiple missing parts that are needed to allow thumbnail previews / trick play. It's probably worth focusing on one specific part of the problem first to ease the design discussion and increase the chances we can merge the changes. Note that there is a considerable overlap with #474, which tracks trick play / thumbnails for HLS and we should try to keep the common functionality generic enough to work with both. I haven't spent a huge amount of time thinking about the details, but I believe that full support will eventually touch many parts of the library:
This list isn't necessarily exhaustive nor does it mean that we really need to make all of these changes. But as you can see, this feature is likely to be very complicated and that's why it would be helpful to focus on one specific subset first. It seems like steps 1 and 2 could be suitable for a PR? What do you think? If you agree, it would be nice to update the doc to focus on this particular part in detail and then we can go from there. |
Thank you @tonihei for the feedback you provided to our design proposal "Add support for thumbnail/preview images from AdaptationSets in DASH". We are very pleased with the efforts and work done so far on the integration of trick play for HLS. Especially the references to tickets and PRs have given us a better insight into the approaches. DASH and HLS have two different approaches to thumbnail support. HLS has its own "thumbnail video representation" and when scrubbing, the representation is completely replaced in the view, so we understand the hints about adding the track to the video track group, pausing the current stream and more. DASH's approach is that the thumbnails are rendered in a small preview window in relation to the scrubbing position on the timebar and the current video doesn't need to be paused. Our approach is similar to how dash.js handles thumbnails. Only the metadata (like the URL) for the thumbnail is provided by exoplayer via an API. The tasks of loading, caching, crop/zoom and rendering of the (tile) images is done by the external app/UI logic. We like the suggestion to plan the process in stages to get a better overview and understanding of the PRs. We have adapted the design proposal accordingly and divided the whole project into 4 milestones to keep track of the progress. We would like to share the updated proposal regarding "Add support for thumbnail/preview images from AdaptationSets in DASH" (last update on 2022-06-30). As the 4th and last milestone we'll integrate the thumbnail support into the demo app. We're looking forward to feedback, discussion and the okay for the start of implementation. Regards |
@tonihei , i would like to get in touch with you regarding CLA. How can i contact you? |
Hi @tonihei, i would like to get in touch with you regarding CLA. We do have a signed CLA from a previous/older project with Google/non ExoPlayer and would like to check if this can be used for this project. How can i contact you? |
Hi, we created a Pull Request for this feature. |
@gorkemg |
@FongMi |
Thanks |
To implement seek thumbnails, usually custom solutions of loading images is used. But there is a standard of defining seek thumbnail images in dash manifest. Please see this document: http://dashif.org/wp-content/uploads/2017/09/DASH-IF-IOP-v4.1-clean.pdf in chapter "6.2.6. Tiles of thumbnail images". Can ExoPlayer dash manifest parser add support for such AdaptionSet/Representation and provide method in player for getting preview image? Thanks.
The text was updated successfully, but these errors were encountered: