-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot select any other than 1st audio/subtitle track in StyledPlayerView
(regression)
#9649
Comments
I can reproduce the issue, thanks! Worth noting that this related to the built-in audio/text selection button in |
When we have multiple overrides for TrackGroups associated with one renderer, we need to look at all of them to find the non-empty one. Empty ones should only be used to remove previously selected tracks for this group and otherwise be ignored. Currently this is broken because the first override (no matter if it's empty or not) is used as the final selection for this renderer. Issue: #9649 #minor-release PiperOrigin-RevId: 407792330
Fixed by the commit above. |
When we have multiple overrides for TrackGroups associated with one renderer, we need to look at all of them to find the non-empty one. Empty ones should only be used to remove previously selected tracks for this group and otherwise be ignored. Currently this is broken because the first override (no matter if it's empty or not) is used as the final selection for this renderer. Issue: #9649 PiperOrigin-RevId: 407792330
When we have multiple overrides for TrackGroups associated with one renderer, we need to look at all of them to find the non-empty one. Empty ones should only be used to remove previously selected tracks for this group and otherwise be ignored. Currently this is broken because the first override (no matter if it's empty or not) is used as the final selection for this renderer. Issue: google/ExoPlayer#9649 #minor-release PiperOrigin-RevId: 407792330
Hi. Thanks in advance. |
I'm migrating from ExoPlayer 2.15.1 to 2.16.0. When I select any audio or subtitle track (in
StyledPlayerView
), other than the first one, there is no audio heard or subtitle visible. I can replicate in something like this:Video used for testing: https://github.com/ietf-wg-cellar/matroska-test-files/blob/master/test_files/test5.mkv
Steps:
It's the same with subtitles. Only the first one (English) are visible. It works fine when using ExoPlayer 2.15.1.
The text was updated successfully, but these errors were encountered: