-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numbers in rew / fwd button not visible in dark mode #9765
Labels
Comments
Could you provide complete steps explaining how to reproduce this? E.g., what device are you using, how are you enabling night mode, and anything else relevant. |
I can reproduce this when using:
It doesn't reproduce when using:
Nevertheless, please confirm your exact use case. |
icbaker
pushed a commit
to androidx/media
that referenced
this issue
Dec 10, 2021
The color set via textAppearance is overridden by any non-null textColor set directly on the style. We always want the specific properties the textAppearance specifies, so set them directly to prevent them from being overridden. #minor-release Issue: google/ExoPlayer#9765 PiperOrigin-RevId: 414967143
ojw28
added a commit
that referenced
this issue
Dec 10, 2021
The color set via textAppearance is overridden by any non-null textColor set directly on the style. We always want the specific properties the textAppearance specifies, so set them directly to prevent them from being overridden. #minor-release Issue: #9765 PiperOrigin-RevId: 414967143
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On Exoplayer 2.16.1:
Light mode:
![image](https://user-images.githubusercontent.com/5836855/145064258-45a2132a-53fa-47e0-a1d9-79d24334fd48.png)
Dark mode:
![image](https://user-images.githubusercontent.com/5836855/145064217-448adbc5-0528-45c6-9215-804f1aec759a.png)
It seems that the numbers are adapted to black/white depending on light/dark mode.
(ref:
ExoPlayer/library/ui/src/main/res/values/styles.xml
Line 97 in 3509f50
The text was updated successfully, but these errors were encountered: