-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables a configurable SocketFactory for the RTSP client #9606
Conversation
@ojw28 do you have a minute to review? Very keen on getting it into the next version. |
@claincly do you have any comment? |
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a section in
To provide more detail on the usage?
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaPeriod.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaSource.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
Show resolved
Hide resolved
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspClient.java
Outdated
Show resolved
Hide resolved
library/rtsp/src/test/java/com/google/android/exoplayer2/source/rtsp/RtspClientTest.java
Outdated
Show resolved
Hide resolved
@claincly the PR has been updated to the latest dev-v2 branch. Would you have time to re-review? |
@claincly Do you have any further comments to address? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/RtspMediaPeriod.java
Show resolved
Hide resolved
library/rtsp/src/test/java/com/google/android/exoplayer2/source/rtsp/RtspClientTest.java
Outdated
Show resolved
Hide resolved
@claincly latest feedback addressed. |
Looks good now, I'll start the merging process on our side. |
Should I rebase again? |
@claincly maybe more luck this week? ;-) |
Hello Sebastian,
I'll keep an eye on this, hopefully get it in this week, thanks for your
patience!
…On Mon, Nov 29, 2021 at 2:57 PM Sebastian Roth ***@***.***> wrote:
@claincly <https://github.com/claincly> maybe more luck this week? ;-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9606 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUCMUUXJJXGNPXOKU6WVJP3UOOIELANCNFSM5GVEMXWA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Our use case is to route RTSP traffic coming from a IoT device through a specific network interface.
In order to achieve that, we setup a custom socket factory (which in turn just forwards to the actual interface).
This MR makes the socket factory configurable via the
RtspMediaPeriod
class etc.The MR contains a few basic tests - feedback welcome.