Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(otel): capture gRPC response metadata in traces #13278

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Dec 12, 2023

Fixes #13275

Capture response metadata over gRPC in traces.

Give special handling to binary headers. I am open to other suggestions on how they should be displayed.

For the tests - note that ValidatePropagator() calls ValidateMetadataFixture::GetMetadata() under the hood, so it both adds a layer of testing and prevents crashes when trying to access the server metadata stored in the grpc::ClientContext.


This change is Reviewable

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (888b7dd) 93.06% compared to head (91724ce) 93.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13278   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files        2137     2137           
  Lines      186610   186640   +30     
=======================================
+ Hits       173666   173698   +32     
+ Misses      12944    12942    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review December 12, 2023 19:25
@dbolduc dbolduc requested a review from a team as a code owner December 12, 2023 19:25
@dbolduc dbolduc merged commit 3c22125 into googleapis:main Dec 13, 2023
59 checks passed
@dbolduc dbolduc deleted the otel-grpc-response-metadata branch December 13, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture server metadata in traces over gRPC
2 participants