feat(bigtable): support bigtable routing cookies #13502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13502 +/- ##
==========================================
- Coverage 93.13% 93.13% -0.01%
==========================================
Files 2185 2185
Lines 190521 190522 +1
==========================================
- Hits 177451 177449 -2
- Misses 13070 13073 +3 ☔ View full report in Codecov by Sentry. |
scotthart
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dbolduc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to do this as part of #13447
This flag tells the server that our client supports the feature. Welcome to Bigtable.
Note that the feature flags are tested. We just check that the serialized value is non-empty and in the format we expect:
google-cloud-cpp/google/cloud/bigtable/internal/bigtable_stub_factory_test.cc
Lines 247 to 248 in 9d54f32
This change is