feat(spanner): add Interval justification #14123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add APIs to flow Interval 24-hour offsets into days, and 30-day periods into months. Seeing as "justification" is included in the relational operators, to best way to verify the results is by conversion to a string. And now that we have `JustifyHours(intvl)`, apply it to the result of `Diff(ts1, ts2, tz)` as required.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14123 +/- ##
==========================================
- Coverage 93.78% 93.23% -0.55%
==========================================
Files 2290 2203 -87
Lines 199353 188946 -10407
==========================================
- Hits 186963 176173 -10790
- Misses 12390 12773 +383 ☔ View full report in Codecov by Sentry. |
coryan
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add APIs to flow Interval 24-hour offsets into days, and 30-day periods into months. Seeing as "justification" is included in the relational operators, to best way to verify the results is by conversion to a string.
And now that we have
JustifyHours(intvl), apply it to the result ofDiff(ts1, ts2, tz)as required.This change is