Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add full object checksum to reader.Attrs #10538

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented Jul 11, 2024

note - JSON does not currently support returning the checksum for range reads

  • GRPC does not support decompression

note - JSON does not currently support returning the checksum for range reads
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 11, 2024
@BrennaEpp BrennaEpp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 11, 2024
@BrennaEpp BrennaEpp removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 17, 2024
@BrennaEpp BrennaEpp marked this pull request as ready for review July 17, 2024 17:42
@BrennaEpp BrennaEpp requested review from a team as code owners July 17, 2024 17:42
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, one doc suggestion.

// Castagnoli93 polynomial, if available.
CRC32C uint32

// Decompressed is true if the object was read decompressed and different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little vague, I would make something that more closely echoes the NewRangeReader docs about transcoding (and/or update those docs to clarify that this field will be True if decompressive transcoding occurs).

@BrennaEpp BrennaEpp requested review from tritone and a team July 17, 2024 18:43
@BrennaEpp BrennaEpp enabled auto-merge (squash) July 19, 2024 17:58
@BrennaEpp BrennaEpp merged commit 245d2ea into googleapis:main Jul 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants