-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): Executor framework server and worker proxy #8714
Merged
harshachinta
merged 26 commits into
googleapis:main
from
harshachinta:spanner-executor-framework-v1
Nov 2, 2023
Merged
feat(spanner): Executor framework server and worker proxy #8714
harshachinta
merged 26 commits into
googleapis:main
from
harshachinta:spanner-executor-framework-v1
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: spanner
Issues related to the Spanner API.
labels
Oct 13, 2023
harshachinta
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Oct 13, 2023
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: m
Pull request size is medium.
labels
Oct 13, 2023
harshachinta
changed the title
feat(spanner): Executor framework server and worker proxy
feat(spanner): Executor framework proto, server and worker proxy
Oct 13, 2023
@arpan14 @gyang-google @rahul2393 |
gyang-google
approved these changes
Oct 19, 2023
arpan14
reviewed
Oct 20, 2023
product-auto-label
bot
added
size: l
Pull request size is large.
and removed
size: xl
Pull request size is extra large.
labels
Oct 20, 2023
harshachinta
changed the title
feat(spanner): Executor framework proto, server and worker proxy
feat(spanner): Executor framework server and worker proxy
Oct 20, 2023
arpan14
reviewed
Oct 20, 2023
harshachinta
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Oct 20, 2023
arpan14
reviewed
Oct 20, 2023
spanner/cloudexecutor/executor/cloud_client_executor_mapping.go
Outdated
Show resolved
Hide resolved
rahul2393
approved these changes
Oct 30, 2023
arpan14
approved these changes
Oct 31, 2023
bhshkh
pushed a commit
that referenced
this pull request
Nov 3, 2023
* feat(spanner): add executor code * feat(spanner): add license headers * feat(spanner): add proto and autogenerated code * feat(spanner): add cloud_executor file which has helper methods * feat(spanner): make code modular * feat(spanner): move autogenerated protos to a different PR * feat(spanner): rename file * feat(spanner): rename * feat(spanner): use string.join * feat(spanner): add file responsibility * feat(spanner): coder refactoring * feat(spanner): coder refactoring * feat(spanner): update go.mod * feat(spanner): lint fixes * feat(spanner): lint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executor Framework for Golang spanner client library.
This PR adds code changes for the following