-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): Add x-goog-spanner-end-to-end-tracing header for requests to Spanner #10241
Open
nareshz
wants to merge
11
commits into
googleapis:main
Choose a base branch
from
nareshz:e2e-trace-optin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nareshz
changed the title
Add x-goog-spanner-end-to-end-tracing header for requests to SpanFE
feat(spanner): Add x-goog-spanner-end-to-end-tracing header for requests to SpanFE
May 21, 2024
dsimil
reviewed
May 21, 2024
dsimil
reviewed
May 21, 2024
dsimil
approved these changes
May 21, 2024
rahul2393
approved these changes
Jun 5, 2024
rahul2393
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2024
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2024
…into e2e-trace-optin
harshachinta
approved these changes
Jun 12, 2024
nareshz
changed the title
feat(spanner): Add x-goog-spanner-end-to-end-tracing header for requests to SpanFE
feat(spanner): Add x-goog-spanner-end-to-end-tracing header for requests to Spanner
Jul 11, 2024
@rahul2393 can this be merged? |
@dsimil Is this ready to be merged. I assume that there is testing going on in backend and this needs to wait until backend is ready? |
…into e2e-trace-optin
rahul2393
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 5, 2024
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Aug 5, 2024
rahul2393
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the Spanner API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable end to end tracing on Spanner layer, client needs to opt-in by setting the
EnableServerSideTracing
flag in ClientConfig. If enabled a new http headerx-goog-spanner-end-to-end-tracing
will be passed in Spanner requests.Design doc: go/cs-tracing-mvp