Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): adds support for X509 workload identity federation #10373

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aeitzman
Copy link
Contributor

No description provided.

@aeitzman aeitzman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 12, 2024
@aeitzman aeitzman requested a review from a team as a code owner June 12, 2024 16:45
@codyoss
Copy link
Member

codyoss commented Jun 12, 2024

cc @andyrzhao

…isibility into whether the client should be overriden
@codyoss codyoss changed the title feat: adds support for X509 workload identity federation feat(auth): adds support for X509 workload identity federation Jun 24, 2024
@codyoss
Copy link
Member

codyoss commented Jun 24, 2024

@andyrzhao Would you mind looking at this too since you are active in this space.

Copy link
Contributor

@andyrzhao andyrzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -121,6 +122,13 @@ type ExecutableConfig struct {
OutputFile string `json:"output_file"`
}

// CertificateConfig reqpresents the options used to set up X509 based workload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "represents"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants