Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: start generating REST clients for betas #6248

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Jun 23, 2022

Start generating as many REGAPIC clients as possible for beta/alpha
surfaces. There are some clients that produce known issues while
generating and these have been excluded from this batch and being
tracked elsewhere separately.

Changes:

feat(analytics): start generating REST client for beta clients

feat(area120): start generating REST client for beta clients

feat(asset): start generating REST client for beta clients

feat(assuredworkloads): start generating REST client for beta clients

feat(automl): start generating REST client for beta clients

feat(bigquery): start generating REST client for beta clients

feat(binaryauthorization): start generating REST client for beta clients

feat(cloudtasks): start generating REST client for beta clients

feat(containeranalysis): start generating REST client for beta clients

feat(dataflow): start generating REST client for beta clients

feat(dataqna): start generating REST client for beta clients

feat(datastream): start generating REST client for beta clients

feat(dialogflow): start generating REST client for beta clients

feat(domains): start generating REST client for beta clients

feat(errorreporting): start generating REST client for beta clients

feat(gkehub): start generating REST client for beta clients

feat(language): start generating REST client for beta clients

feat(lifesciences): start generating REST client for beta clients

feat(memcache): start generating REST client for beta clients

feat(metastore): start generating REST client for beta clients

feat(osconfig): start generating REST client for beta clients

feat(oslogin): start generating REST client for beta clients

feat(phishingprotection): start generating REST client for beta clients

feat(privatecatalog): start generating REST client for beta clients

feat(recaptchaenterprise): start generating REST client for beta clients

feat(recommender): start generating REST client for beta clients

feat(redis): start generating REST client for beta clients

feat(scheduler): start generating REST client for beta clients

feat(secretmanager): start generating REST client for beta clients

feat(servicedirectory): start generating REST client for beta clients

feat(speech): start generating REST client for beta clients

feat(talent): start generating REST client for beta clients

feat(videointelligence): start generating REST client for beta clients

feat(vision): start generating REST client for beta clients

feat(webrisk): start generating REST client for beta clients

feat(workflows): start generating REST client for beta clients

Start generating as many regapic clients as possible for beta/alpha
surfaces. There are some clients that produce known issues while
generating and these have been excluded from this batch and being
tracked elsewhere seperatly.
Changes:

feat(analytics): start generating REST client for beta clients

feat(area120): start generating REST client for beta clients

feat(asset): start generating REST client for beta clients

feat(assuredworkloads): start generating REST client for beta clients

feat(automl): start generating REST client for beta clients

feat(bigquery): start generating REST client for beta clients

feat(binaryauthorization): start generating REST client for beta clients

feat(cloudtasks): start generating REST client for beta clients

feat(containeranalysis): start generating REST client for beta clients

feat(dataflow): start generating REST client for beta clients

feat(dataqna): start generating REST client for beta clients

feat(datastream): start generating REST client for beta clients

feat(dialogflow): start generating REST client for beta clients

feat(domains): start generating REST client for beta clients

feat(errorreporting): start generating REST client for beta clients

feat(gaming): start generating REST client for beta clients

feat(gkehub): start generating REST client for beta clients

feat(language): start generating REST client for beta clients

feat(lifesciences): start generating REST client for beta clients

feat(memcache): start generating REST client for beta clients

feat(metastore): start generating REST client for beta clients

feat(osconfig): start generating REST client for beta clients

feat(oslogin): start generating REST client for beta clients

feat(phishingprotection): start generating REST client for beta clients

feat(privatecatalog): start generating REST client for beta clients

feat(recaptchaenterprise): start generating REST client for beta clients

feat(recommender): start generating REST client for beta clients

feat(redis): start generating REST client for beta clients

feat(scheduler): start generating REST client for beta clients

feat(secretmanager): start generating REST client for beta clients

feat(security): start generating REST client for beta clients

feat(servicedirectory): start generating REST client for beta clients

feat(speech): start generating REST client for beta clients

feat(talent): start generating REST client for beta clients

feat(videointelligence): start generating REST client for beta clients

feat(vision): start generating REST client for beta clients

feat(webrisk): start generating REST client for beta clients

feat(workflows): start generating REST client for beta clients
@codyoss codyoss requested review from a team as code owners June 23, 2022 21:40
@codyoss codyoss requested review from a team and GaoleMeng June 23, 2022 21:40
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jun 23, 2022
@codyoss codyoss enabled auto-merge (squash) June 23, 2022 21:41
@codyoss codyoss requested review from quartzmo and vam-google and removed request for GaoleMeng June 23, 2022 21:41
Copy link

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss codyoss disabled auto-merge June 24, 2022 15:06
@codyoss codyoss enabled auto-merge (squash) June 24, 2022 15:06
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did some (but not all) modules need google.golang.org/protobuf added to go.mod?

Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the files for a single client, assuredworkloads/apiv1beta1.

It LGTM.

I'll approve now, but will pull the branch and try to use one of the rest clients against a live service.

@codyoss codyoss merged commit 25b7775 into googleapis:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants