Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove classifier for Python 3.4 for end-of-life. #7535

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

crwilcox
Copy link
Contributor

Python 3.4 has reached EOL. https://www.python.org/dev/peps/pep-0429/

At this point we should remove the classifier for 3.4 and discourage its use. This change doesn't prevent users from installing this library on 3.4. Doing so would require rev-ing versions of our libraries and create a good deal of noise. My suggestion is that we modify python_requires as other breaking changes come, removing 3.4 at that point.

@crwilcox crwilcox requested a review from tswast as a code owner March 19, 2019 13:22
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2019
@tseaver
Copy link
Contributor

tseaver commented Mar 19, 2019

@crwilcox

My suggestion is that we modify python_requires as other breaking changes come, removing 3.4 at that point.

We aren't likely to make changes which break 3.4 before we also drop 2.7 support:

  • New syntax is obviously problematic (e.g. we've already told folks that async / await redesign efforts are blocked by 2.7 compat).
  • New library stuff likewise (minimal in 3.5, and again blocked by 2.7 compat).

See: https://docs.python.org/3/whatsnew/3.5.html

@crwilcox
Copy link
Contributor Author

@tseaver we are 100% on the same page on this one. If we batch it with 2.7 it will save a major bump and be less disruptive.

@crwilcox crwilcox merged commit 3a9a889 into googleapis:master Mar 20, 2019
atulep pushed a commit that referenced this pull request Apr 3, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
atulep pushed a commit that referenced this pull request Apr 18, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jun 4, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Jul 6, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Aug 15, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Sep 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 21, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 22, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
parthea pushed a commit that referenced this pull request Oct 31, 2023
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants