Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-bigtable Loading
base: v4.5.1
Choose a base ref
...
head repository: googleapis/nodejs-bigtable Loading
compare: v4.5.2
Choose a head ref
  • 6 commits
  • 12 files changed
  • 5 contributors

Commits on May 8, 2023

  1. Configuration menu
    Copy the full SHA
    436e778 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. test: Make the mock server test async (#1283)

    * Make the mock server test async
    
    This test uses the done callback which looks confusing. We should. make the test async for readability.
    
    * test: Make the mock server test async
    
    * Remove the unnecessary before block
    
    The service does not need to be initialized in a before block. Move it to where the server is initialized.
    danieljbruce committed May 19, 2023
    Configuration menu
    Copy the full SHA
    6bda5be View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. test: test ReadRows logic with local gRPC server (#1282)

    * test: test ReadRows logic with local gRPC server
    
    * test: PR feedback
    
    * test: fix race condition in initialization
    
    * test: PR feedback, renaming a variable for readability
    
    * test: add test for asynchronous end() call
    
    * test: only set lastScannedRowKey for completed rows
    
    * test: refactor, fix lastScannedRowKey logic, PR feedback
    
    * test: rename test suite
    
    ---------
    
    Co-authored-by: danieljbruce <[email protected]>
    alexander-fenster and danieljbruce committed May 22, 2023
    Configuration menu
    Copy the full SHA
    52a6711 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c7c5ae View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. fix: Parsing for qualifiers with colon characters (#1277)

    * Fix parsing for qualifiers with colon characters
    
    * Update ci.yaml
    
    * fix: Support names with no qualifier
    
    * revert: remove workflow_dispatch
    
    * fix: Update test to check null qualifiers instead of undefined
    
    * fix: Respect column names without qualifiers
    
    * fix: Clean up for lint errors
    
    * fix: Remove remaining trailing space
    
    * revert: "fix: Update test to check null qualifiers instead of undefined"
    
    This reverts commit 1275dd5.
    
    * fix: Allow undefined qualifiers in ParsedColumn
    
    * test: Add test for qualifier names with colons
    
    ---------
    
    Co-authored-by: danieljbruce <[email protected]>
    KDB223 and danieljbruce committed May 24, 2023
    Configuration menu
    Copy the full SHA
    b80f533 View commit details
    Browse the repository at this point in the history
  2. chore(main): release 4.5.2 (#1287)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] committed May 24, 2023
    Configuration menu
    Copy the full SHA
    86b8f7b View commit details
    Browse the repository at this point in the history
Loading