Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/nodejs-datastore Loading
base: v7.5.0
Choose a base ref
...
head repository: googleapis/nodejs-datastore Loading
compare: v7.5.1
Choose a head ref
  • 4 commits
  • 11 files changed
  • 4 contributors

Commits on Apr 5, 2023

  1. test: Remove mock so that future tests will not be affected by the mo…

    …ck (#1099)
    
    * Ensure the mock isn’t permanent for other cases
    
    Reassign this mock back to what it was because future tests will rely on this being the proper value.
    
    * Add async to verify the change works
    
    Async will run all the tests twice failing if the prior change was not implemented.
    
    * Revert "Add async to verify the change works"
    
    This reverts commit 57855a3.
    
    * Adjust the comment slightly
    
    Adjust the comment slightly to address the fact that we are changing the mocked function back to the way it was.
    
    * Refactor the mock out into a constant
    
    The mock should be a constant instead of repeating a code fragment that must be the same.
    
    * Surround with try/finally
    
    We can use try/finally so that even if the test fails the mock gets reset.
    
    * Revert "Surround with try/finally"
    
    This reverts commit 73bea28.
    
    * Have a fake entity init state
    
    Have a fake entity init state and then before each test initialize the fakeEntity from the fakeEntityInit state.
    
    * Remove resetting the mock in individual tests
    
    Now that we initialize the fake entity at the beginning of every single test, we do not need to reset the mock in that one test anymore.
    
    * Eliminate unused variable
    
    Variable is not used anymore so should be eliminated from the code change.
    danieljbruce committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bc40a99 View commit details
    Browse the repository at this point in the history
  2. chore: update import paths for Go targets to match open source locati…

    …on (#1100)
    
    * chore: update import paths for Go targets to match open source location
    chore: update go_package in protos to match open source location
    chore: add explicit release levels to Go gapic targets
    
    PiperOrigin-RevId: 520705454
    
    Source-Link: googleapis/googleapis@1cfcea4
    
    Source-Link: googleapis/googleapis-gen@15732ab
    Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTU3MzJhYjc1MjExYjAyNTU0MzNkNmY4NzQxNWU4YTNjZTQ2NjgyNiJ9
    
    * 🦉 Updates from OwlBot post-processor
    
    See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
    
    ---------
    
    Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
    Co-authored-by: danieljbruce <[email protected]>
    3 people committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c98f4e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. fix: Allow user to set custom endpoints (#1101)

    * Write a test for custom endpoints
    
    With the code in its present state, this test should fail. A fix for regional endpoints intends to clean this up.
    
    * Limit setting credentials to insecure
    
    Only set the credentials to insecure if the custom endpoint is localhost and credentials are not provided. This way the user can set custom endpoints with the client and the request will work.
    
    * Change the tests for custom endpoints
    
    There is a test that uses a mock which is preventing the base url from being set. The test should be more realistic and when it is, the test passes with the new change.
    
    * Add another localhost option
    
    There is a third way the user can specify localhost. We should include this way as an option.
    danieljbruce committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    e79fa49 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. chore(main): release 7.5.1 (#1102)

    Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
    release-please[bot] committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    10d61df View commit details
    Browse the repository at this point in the history
Loading