Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use sinon for mocking #168

Merged
merged 1 commit into from
Aug 12, 2018
Merged

test: use sinon for mocking #168

merged 1 commit into from
Aug 12, 2018

Conversation

JustinBeckwith
Copy link
Contributor

This will make moving to es classes a lot easier.

@JustinBeckwith JustinBeckwith requested a review from a team August 12, 2018 01:56
@ghost ghost assigned JustinBeckwith Aug 12, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2018
@codecov
Copy link

codecov bot commented Aug 12, 2018

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #168   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         646    646           
=====================================
  Hits          646    646

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b0511...adc1be2. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 19d0ef2 into googleapis:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants