Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): use index to determine array struct member value #1775

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

andrao
Copy link
Contributor

@andrao andrao commented Jan 18, 2023

Where the STRUCT value is an array, always determine inner member value using field index.

Error case is reproduced by the new should decode array STRUCT value and inner members test case in test/codec.ts.

Fixes #1774.


  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@andrao andrao requested review from a team as code owners January 18, 2023 09:28
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Jan 18, 2023
Where the STRUCT value is an array, always determine inner member value using field index.

STRUCT value is represented by var 'decoded'.

Refs: googleapis#1774
@surbhigarg92 surbhigarg92 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 19, 2023
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 23, 2023
@surbhigarg92 surbhigarg92 merged commit fc2b695 into googleapis:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error parsing STRUCT with JSON "keys" field
3 participants