Database.getDatabaseDialect's "cb" argument is never used

[odeke-em]

If we examine the method "getDatabaseDialect"

nodejs-spanner/src/database.ts

Lines 1530 to 1553 in 30151ca

	getDatabaseDialect(
	options: CallOptions,
	callback: GetDatabaseDialectCallback
	): void;
	async getDatabaseDialect(
	optionsOrCallback?: CallOptions | GetDatabaseDialectCallback,
	cb?: GetDatabaseDialectCallback
	): Promise<
	| EnumKey<typeof databaseAdmin.spanner.admin.database.v1.DatabaseDialect>
	| undefined
	> {
	const gaxOptions =
	typeof optionsOrCallback === 'object' ? optionsOrCallback : {};
	if (
	this.databaseDialect === 'DATABASE_DIALECT_UNSPECIFIED' ||
	this.databaseDialect === null ||
	this.databaseDialect === undefined
	) {
	const [metadata] = await this.getMetadata(gaxOptions);
	this.databaseDialect = metadata.databaseDialect;
	}
	return this.databaseDialect || undefined;
	}

we can see that the callback passed in is never used. I found this while working on trace instrumentation for these libraries.

[alkatrivedi]

Hi @odeke-em, thanks for pointing it out. I have raised a PR to fix this issue