Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unused references to generated samples #1815

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

dansaadati
Copy link
Contributor

The Spanner team is not using auto-generated samples, so references to them should be removed.

#1517

This does not render correctly in documentation, so
it should be removed.
@dansaadati dansaadati requested review from a team as code owners March 1, 2023 20:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Mar 1, 2023
@dansaadati dansaadati added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 2, 2023
@sofisl
Copy link
Contributor

sofisl commented Mar 7, 2023

This will partially fix #1517, but we still need to fix publishing as well (#1813)

@surbhigarg92 surbhigarg92 merged commit a1603ef into main Mar 8, 2023
@surbhigarg92 surbhigarg92 deleted the remove-generated-sample-references branch March 8, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants