Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dev containers #1854

Merged
merged 4 commits into from
May 25, 2023
Merged

chore: dev containers #1854

merged 4 commits into from
May 25, 2023

Conversation

surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented May 23, 2023 •
edited
Loading

No description provided.

@surbhigarg92 surbhigarg92 requested review from a team as code owners May 23, 2023 12:27
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/nodejs-spanner API. labels May 23, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 24, 2023
asthamohta
asthamohta approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@asthamohta asthamohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@surbhigarg92 surbhigarg92 added the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 70fee08 into googleapis:main May 25, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2023
@surbhigarg92 surbhigarg92 deleted the dev_containers branch October 23, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

@asthamohta asthamohta asthamohta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surbhigarg92 @rahul2393 @asthamohta