Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update custom retry and timeout sample #1918

Merged
merged 3 commits into from
Sep 28, 2023
Merged

docs: update custom retry and timeout sample #1918

merged 3 commits into from
Sep 28, 2023

Conversation

olavloite
Copy link
Contributor

Fixes a couple of minor issues in the retry- and timeout sample:

  1. Remove DeadlineExceeded as a retryable code, as the sample uses a single timeout and will not retry on DeadlineExceeded anyways, meaning that the addition of that error code was just confusing.
  2. Update the maxBackoff to 16 seconds. We are setting this value to 16 seconds for all client libraries, as it makes the sample confusing when the max backoff is larger than the total timeout (60 seconds).

The documentation page that uses this sample is https://cloud.google.com/spanner/docs/custom-timeout-and-retry

Do not merge: Please hold off on merging until all the samples have been updated.

@olavloite
docs: update custom retry and timeout sample
9cd0534 
Fixes a couple of minor issues in the retry- and timeout sample:

1. Remove DeadlineExceeded as a retryable code, as the sample uses a single timeout and will not retry on DeadlineExceeded anyways, meaning that the addition of that error code was just confusing.
1. Update the maxBackoff to 16 seconds. We are setting this value to 16 seconds for all client libraries, as it makes the sample confusing when the max backoff is larger than the total timeout (60 seconds).

The documentation page that uses this sample is https://cloud.google.com/spanner/docs/custom-timeout-and-retry

Do not merge: Please hold off on merging until all the samples have been updated.
@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 21, 2023
@olavloite olavloite requested review from a team as code owners September 21, 2023 12:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Sep 21, 2023
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 28, 2023
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 45cd425 into main Sep 28, 2023
19 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-custom-timeout-and-retry-sample branch September 28, 2023 07:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olavloite @surbhigarg92