Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: admin samples #2013

Merged
merged 8 commits into from
Mar 6, 2024
Merged

chore: admin samples #2013

merged 8 commits into from
Mar 6, 2024

Conversation

alkatrivedi
Copy link
Contributor

This PR contains missing admin samples/integration tests.

@alkatrivedi alkatrivedi requested review from a team as code owners March 5, 2024 07:39
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 16 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Mar 5, 2024
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Mar 5, 2024
@alkatrivedi alkatrivedi requested a review from arpan14 March 5, 2024 12:28
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 5, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 5, 2024
arpan14
arpan14 reviewed Mar 6, 2024
View reviewed changes
samples/README.md Show resolved Hide resolved
samples/archived/database-get-default-leader.js Show resolved Hide resolved
samples/database-get-default-leader.js Show resolved Hide resolved
samples/get-instance-config.js Show resolved Hide resolved
samples/schema.js Show resolved Hide resolved
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2024
@alkatrivedi alkatrivedi added the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 5bf9f30 into googleapis:main Mar 6, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpan14 arpan14 arpan14 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alkatrivedi @arpan14 @yoshi-kokoro