Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes getSignedUrl Return Type #496

Merged
merged 3 commits into from
Nov 1, 2018
Merged

Fixes getSignedUrl Return Type #496

merged 3 commits into from
Nov 1, 2018

Conversation

reichjustin
Copy link
Contributor

@reichjustin reichjustin commented Nov 1, 2018

Fixes #497

Currently, the getSignedUrl type is returning GetSignedPolicyResponse. It should be GetSignedUrlResponse

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

getSignedUrl response type should be GetSignedUrlResponse not GetSignedPolicyResponse
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 1, 2018
@reichjustin
Copy link
Contributor Author

I Agreed

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 1, 2018
src/file.ts Outdated
@@ -2311,7 +2311,7 @@ class File extends ServiceObject {
* region_tag:storage_generate_signed_url
* Another example:
*/
getSignedUrl(cfg: GetSignedUrlConfig): Promise<GetSignedPolicyResponse>;
getSignedUrl(cfg: GetSignedUrlConfig): Promise<GetSignedUrlResponse>;
getSignedUrl(cfg: GetSignedUrlConfig, callback: GetSignedUrlCallback): void;
getSignedUrl(cfg: GetSignedUrlConfig, callback?: GetSignedUrlCallback):
void|Promise<GetSignedPolicyResponse> {

This comment was marked as spam.

This comment was marked as spam.

Updating the other response type.
@JustinBeckwith
Copy link
Contributor

Thank you so much for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants