-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes getSignedUrl Return Type #496
Conversation
getSignedUrl response type should be GetSignedUrlResponse not GetSignedPolicyResponse
Update file.ts
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I Agreed |
CLAs look good, thanks! |
src/file.ts
Outdated
@@ -2311,7 +2311,7 @@ class File extends ServiceObject { | |||
* region_tag:storage_generate_signed_url | |||
* Another example: | |||
*/ | |||
getSignedUrl(cfg: GetSignedUrlConfig): Promise<GetSignedPolicyResponse>; | |||
getSignedUrl(cfg: GetSignedUrlConfig): Promise<GetSignedUrlResponse>; | |||
getSignedUrl(cfg: GetSignedUrlConfig, callback: GetSignedUrlCallback): void; | |||
getSignedUrl(cfg: GetSignedUrlConfig, callback?: GetSignedUrlCallback): | |||
void|Promise<GetSignedPolicyResponse> { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Updating the other response type.
Thank you so much for the fix! |
Fixes #497
Currently, the getSignedUrl type is returning GetSignedPolicyResponse. It should be GetSignedUrlResponse