Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Bucket Policy Only related system test #579

Merged
merged 4 commits into from
Jan 16, 2019
Merged

test: Bucket Policy Only related system test #579

merged 4 commits into from
Jan 16, 2019

Conversation

jkwlui
Copy link
Member

@jkwlui jkwlui commented Jan 15, 2019 •
edited
Loading

Contains the following asserts:

  • General Bucket Policy Only assertions
    • Object acl get or update fails w/ 400
  • Insert a new bucket with Bucket Policy Only Enabled.
    • Verify that objects can be written to the bucket by project Owners and Editors without any further configuration
  • Verify that default object acl and object acls are preserved
    • Create a bucket
    • Insert an object
    • Enable BPO
    • Disable BPO
    • Check that the object's ACLs are still there

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2019
@jkwlui jkwlui changed the title Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion) test: Bucket Policy Only related system test Jan 15, 2019
@jkwlui jkwlui requested a review from frankyn January 15, 2019 23:18
@jkwlui jkwlui self-assigned this Jan 16, 2019
frankyn
frankyn approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kinwa91! LGTM.

@jkwlui jkwlui merged commit 4e262f2 into master Jan 16, 2019
@jkwlui jkwlui deleted the bpo-system-tests branch January 16, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@frankyn frankyn frankyn approved these changes

Assignees

@jkwlui jkwlui

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkwlui @JustinBeckwith @frankyn @googlebot