Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add requires_billing, retire .cloud-repo-tools.json #644

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 26, 2019

Adds the new requires_billing field, which allows us to toggle out sections of the README depending on whether a user needs to activate billing on their account to access the given service (see).

Given that this is the last piece of information we actively needed from .cloud-repo-tools.json, I'm killing this now unused meta-information file.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 26, 2019
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #644 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #644   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files           9        9           
  Lines         874      874           
  Branches       99       99           
=======================================
  Hits          856      856           
  Misses          9        9           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2248a61...620dd4e. Read the comment docs.

@bcoe bcoe merged commit b7e446c into master Mar 26, 2019
@bcoe bcoe deleted the requires-billing branch March 26, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants