Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pyarrow version check for range support #1914

Merged
merged 2 commits into from
May 9, 2024

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented May 9, 2024

  • adds a version check for pyarrow
  • consolidates warning messages
  • use a constant in _versions_helper.py for checking range support in both pandas and pyarrow

TODO: add nox test session for the case when a newer pandas is installed, but pyarrow is very old.

Fixes #1912 🦕

@Linchin Linchin requested review from a team as code owners May 9, 2024 00:29
@Linchin Linchin requested a review from obada-ab May 9, 2024 00:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 9, 2024
@Linchin Linchin requested a review from tswast May 9, 2024 00:29
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

google/cloud/bigquery/_versions_helpers.py Show resolved Hide resolved
@tswast
Copy link
Contributor

tswast commented May 9, 2024

TODO: add nox test session for the case when a newer pandas is installed, but pyarrow is very old.

Since we unit test on multiple versions of Python, we could use one of the middle constraints files for this. That said, I think we usually just mock out the version mismatches in unit tests.

@Linchin Linchin merged commit a86d7b9 into googleapis:main May 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency version mismatch on pyarrow
3 participants