Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify Client._connection.extra_headers functionality #1932

Merged
merged 2 commits into from
May 29, 2024

Conversation

tswast
Copy link
Contributor

@tswast tswast commented May 24, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners May 24, 2024 20:10
@tswast tswast requested a review from farhan0102 May 24, 2024 20:10
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 24, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 24, 2024
@tswast tswast requested review from chalmerlowe and removed request for farhan0102 May 24, 2024 21:31
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast enabled auto-merge (squash) May 29, 2024 19:25
@tswast tswast merged commit 67ec0c1 into main May 29, 2024
21 checks passed
@tswast tswast deleted the tswast-extra_headers branch May 29, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants